one-page-website-html-css-project icon indicating copy to clipboard operation
one-page-website-html-css-project copied to clipboard

removed aling-items from service bottom to make sure all service items stay of same height

Open milindpatel11 opened this issue 5 years ago • 1 comments

when service items have different length of content, one with bigger content is higher and symmetry of service items is gone. removing align-items: center from service bottom aligns all height to biggest content box ( I just commented it out for now). Alternatively, we can do align-items: stretch on .service-bottom OR align-self: stretch on .service-item . Feel free to test these and implement change you like.

Screen Shot 2020-12-12 at 5 28 50 PM

milindpatel11 avatar Dec 12 '20 12:12 milindpatel11

I commented out instead of deleting. First time contributing to GitHub project. Learned to practice and start writing basic site using your tutorial and thanks for that. I have been making bilingual react sites now using inspiration on a few section from your tutorial and had noticed the service item issue earlier with simple non-react version of this site a few months ago and it notices again with my react version recently, to fix I had to do some debugging and I uses stretch to solve this nd thought it will be good to contribute (though just one line of CSS) to project that I had learned a lot from (specifically on header effects etc). Feel free to accept, reject or suggest something else.

milindpatel11 avatar Dec 12 '20 12:12 milindpatel11