MySQL-AutoXtraBackup

MySQL-AutoXtraBackup copied to clipboard

Completely rewrite, restructure this project or abandone

3

Dear all, As this project was developed with the wrong design and architecture, it is nearly impossible to test, cover or change and fix something easily. This leads me to...

ShahriyarR

Major refactorings - iteration 1 (Sourcery refactored)

1

Pull Request #458 refactored by [Sourcery](https://sourcery.ai/github/). If you're happy with these changes, merge this Pull Request using the *Squash and merge* strategy. **NOTE**: As code is pushed to the original...

sourcery-ai[bot]

release_v3.0

1

The major code refactorings and project restructuring.

ShahriyarR

Major refactorings - iteration 1

1

ShahriyarR

Update copy_back.py

1

there is no key `data_dir` in options_obj.backup_options, `self.backup_options.get("xtra_options") or ""` is used to prevent get a `None` after the `--copy-back` option, like ` /usr/bin/xtrabackup --copy-back None --target-dir` option `--data_dir` for...

icy1900

Config not generated on setup

5

Hi, When installing the new v.2 (awesome by the way!) the config dir ~/.autoxtrabackup and config files are not created. Host: Debian 10. Command: ``` root@dev:~# pip3 install mysql-autoxtrabackup ```...

JasperAlgra

Release v2.0.3

2

ShahriyarR

archive_max_duration - ValueError: could not convert string to float: 'None'

7

Hi, I have installed v2.0.2 and this is the log: ``` 2021-08-13 11:00:02 INFO [process_runner:69] SUBPROCESS /usr/bin/mysqladmin COMPLETED with exit code: 0 2021-08-13 11:00:02 INFO [check_env:101] OK: /usr/bin/mysql exists 2021-08-13...

pericajakimov

Return status for inc_backup() is IGNORED !?

5

Hi you are ignoring the result (0/1) for inc_backup(), the entire autoxtrbackup run results in a false positive exitcode! That may not be the best practice :-( https://github.com/ShahriyarR/MySQL-AutoXtraBackup/blob/72ca0a834f12331c3ed8cde17ea77a8ce573a774/master_backup_script/backuper.py#L753 https://github.com/ShahriyarR/MySQL-AutoXtraBackup/blob/72ca0a834f12331c3ed8cde17ea77a8ce573a774/master_backup_script/backuper.py#L760 impact:...

WernerMairl

DryRun causes UnboundLocalError: local variable 'status' referenced before assignment

1

Finding on master: error thrown here: https://github.com/ShahriyarR/MySQL-AutoXtraBackup/blob/72ca0a834f12331c3ed8cde17ea77a8ce573a774/backup_prepare/prepare.py#L630 caused/impacted by the following line in case dryrun! https://github.com/ShahriyarR/MySQL-AutoXtraBackup/blob/72ca0a834f12331c3ed8cde17ea77a8ce573a774/backup_prepare/prepare.py#L539 Assumtion: some "else" for dryrun should initialize status (status not initialzed for dry-run)! regards...

WernerMairl