Antonio Salazar Cardozo

Results 286 comments of Antonio Salazar Cardozo

Okay, did a bit of investigating here. This is a bit tangled up because `S.jsToAppend` looks up the post page functions, but so does `CometActor`'s `fixedRender`. Both are used by...

Oh… I think this is actually entirely fixed as of #1711, and therefore as of Lift 3.0.0. Will need to double-check.

:-1: on this behavior. I think `or` has a clear behavior across `Box`. This sounds like a better solution would be a separate function that chains two `Failure`s together. It...

It looks like this issue was originally related to not using `LiftRules.resourceBundleFactories`, but I see we're using it at https://github.com/lift/framework/blob/master/web/webkit/src/main/scala/net/liftweb/http/S.scala#L968 now (or maybe we were then as well and just...

I thought this got fixed a while back with the special function in the function map that handles requestvar restoration?

If we're going to do this, we need to get the deprecation wheels moving in 2.6 and remove it in 3.0.

We definitely shouldn't deprecate unless we have a clear plan for getting rid of it. I noticed it was pretty thoroughly baked in as well. Some research is probably a...

Yeah, when I was assigning these around I wasn't planning milestones, just using M4 to mark things we eventually wanted in 2.6.

Any updated thoughts here as we prep for an RC?

Heh. Yeah, RC means we're done with changes like this.