Jonathan de Jong
Jonathan de Jong
oh sorry, i was partially recalling something from MSC2844, which says something about the timetable for deprecation and removal for endpoints and features. i meant with "bracket" as a range...
Furthermore, this would make it possible to simply annotate ruma with a crate feature such as `"v1.2"`, `"v1.3"`, `"pre-spec"`, `"latest-formal"`, and only have those options systematically available to use, and...
Alright, for this, i'll first create a `msc1902` submodule under `ruma_client_api::media`, and duplicate the endpoints in there with the right paths. However, after this stabilizes, I think that the endpoints...
Blocked on https://github.com/ruma/ruma/issues/1118, as I want to have this endpoint transition ergonomically to the new ones.
Basically: Add something like a `.sign()` function to either `ServerSigningKeys`, `Raw`, or the response type to the endpoint, with similar parameters that `ruma_signatures::functions::sign_json` has.
I think we should leave validation like this optional, but default "on", with `compat` we might delegate it to an opt-in validation effort ("this PDU is technically not valid") for...
Also, i think that with `compat`/compatibility functionality, it'd be a good idea to keep a reminder of "be strict with what you send, but relaxed with what you receive" associated...
Would serialising/deserialising to a generic "object" value work? Or would that add loads of overhead for no particular good reason?
FWIW this is required for [ruma/lb](https://github.com/ruma/lb), and a TAIT approach in https://github.com/ruma/ruma/issues/706 is suggested that exposes `Body` as `impl Serialize`, and then give that through `try_into_http_request() -> Result`, which can...
I'm only glancing through it quickly, but it seems `r0::push` has a lot of duplication between it and endpoint-used structs.