Shahar Har-Shuv

icon company Quotient Technology icon location New York City icon location Tech Lead at Neptune Retail Solutions Founder and main maintainer of the open source ear training app Open-Ear, and angular form library "formal"

Results 65 comments of Shahar Har-Shuv

queryOptions should to pass initialData with a callback that is potentially returning undefined

Opened a PR that fixes this: https://github.com/TanStack/query/pull/7351

queryOptions should to pass initialData with a callback that is potentially returning undefined

The problematic types are defined in angular-query-experimental. If an undefined return type is not supported than I'm not sure how the common use case will work. This example ([from the...

queryOptions should to pass initialData with a callback that is potentially returning undefined

> I don't think your proposed solution is right though. I think we should rather extend UndefinedInitialDataOptions When looking at the types more closely I believe you are correct. According...

queryOptions should to pass initialData with a callback that is potentially returning undefined

> okay interestingly, we have test that cover this case already, and they don't fail: It doesn't fail because you use `useQuery` directly. The bug (both in angular and react)...

queryOptions should to pass initialData with a callback that is potentially returning undefined

I fixed the PR per feedback: https://github.com/TanStack/query/pull/7351