Shahar Har-Shuv comments

Results 65 comments of


                                            Shahar Har-Shuv

feat(angular-query-experimental): run query options callbacks in injection context

I get what you are saying, but in practice, and in many use cases, not being able to do it here just makes DX more difficult. Here's an example: ```...

feat(angular-query-experimental): run query options callbacks in injection context

You first example wouldn't work because you are injecting inside the `todosQueryOptions` method. When you call it in a non-injection context it will throw. I assume you meant that you...

fix(angular-query-experimental): allow returning undefined in initialData function

It seems like the styling changes were done automatically on commit by lint-staged. Let me know if you think something in my set up is wrong and it shouldn't have...

fix(angular-query-experimental): allow returning undefined in initialData function

I fixed the prettier issue

fix(angular-query-experimental): allow returning undefined in initialData function

@TkDodo Done!

fix(angular-query-experimental): allow returning undefined in initialData function

@TkDodo @arnoud-dv Can this be merged?

fix(angular-query-experimental): run mutation callback in injection context

Resolved conflicts. @arnoud-dv can you review?

fix(angular-query-experimental): run mutation callback in injection context

The tests failures don't seem to be related to my change, as they fail in the react adapter.

fix(angular-query-experimental): run mutation callback in injection context

Can this be merged?

fix(angular-query-experimental): run mutation callback in injection context

@arnoud-dv Apparently the error wasn't caught by the test, thanks for noticing. I took @kfrancois's approach of using an "errorSpy" and manually catching the error. Now the test will fail...