Ashley Davis
Ashley Davis
Results in a confusing math error when accessing Component IDs, since none exist yet. This is probably unavoidable short of fixing the library to use constexpr Component IDs.
Currently fails confusingly while trying to create the Family hash - should fail sooner.
Currently timeouts for checking for success are scattered across tests (e.g. [here](https://github.com/cert-manager/csi-driver-spiffe/blob/17ff261113d759f54808b96aeeeee45359291ebb/test/e2e/suite/approval/approval.go#L126-L129)) and so are hard to change. They're also quite low and could easily flake in a resource constrained...
Loggers for the driver and the approver are currently ultimately created by [`klog.TODO`](https://pkg.go.dev/k8s.io/klog/v2#TODO) in [this section of code](https://github.com/cert-manager/csi-driver-spiffe/blob/17ff261113d759f54808b96aeeeee45359291ebb/internal/flags/flags.go#L71). The flow control here is confusing and could be improved, and TODO...
Today, approver-policy can't explicitly deny any certs by default because it has to account for the possibility that there's another approver working in the cluster which might make an approval...
When a user creates a custom issuer, they'll currently need to give permission to approver-policy to approve CertificateRequests from that issuer, which will look something like the below: ```yaml apiVersion:...
We discussed curve parameters and checking for curves in standup earlier, and I said I'd look into approver-policy because checking curves is an important part of that. This issue documents...
We [1] generally agree that passwords on JKS / PKCS#12 files solve no problems in any practical threat model when using cert-manager or trust-manager. That can be incredbly unintuitive for...
We run [gen-crd-api-reference-docs](https://github.com/ahmetb/gen-crd-api-reference-docs) in "markdown" mode, where it will process doc comments as markdown, but it's buggy and incorrect for some links. An example is [this line](https://github.com/cert-manager/cert-manager/blob/1038ca44948702ff7c2063aec367be2b61831608/pkg/apis/certmanager/v1/types_issuer.go#L192) which is converted...
# cert-manager Graduation Application @kgamanji suggested we raise this issue to replace the PR we raised initially (#1212), as the process for graduation has changed since we raised that PR....