genrl icon indicating copy to clipboard operation
genrl copied to clipboard

CEM

Open hades-rp2010 opened this issue 5 years ago • 7 comments
trafficstars

Wrt #363

hades-rp2010 avatar Oct 05 '20 21:10 hades-rp2010

Codecov Report

Merging #373 into master will decrease coverage by 0.03%. The diff coverage is 90.09%.

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   91.28%   91.25%   -0.04%     
==========================================
  Files          90       92       +2     
  Lines        3809     3910     +101     
==========================================
+ Hits         3477     3568      +91     
- Misses        332      342      +10     
Impacted Files Coverage Δ
genrl/agents/modelbased/base.py 71.42% <71.42%> (ø)
genrl/agents/modelbased/cem/cem.py 94.87% <94.87%> (ø)
genrl/agents/__init__.py 100.00% <100.00%> (ø)

codecov[bot] avatar Oct 05 '20 21:10 codecov[bot]

This pull request introduces 3 alerts when merging a90e8d0e834cdbc6fe777dc0a50b01c651f9fc59 into 52b0b4c0399d612c68b705c1e718dfd8e5d22ce3 - view on LGTM.com

new alerts:

  • 3 for Unused import

lgtm-com[bot] avatar Oct 05 '20 22:10 lgtm-com[bot]

This pull request introduces 4 alerts when merging 3b2067d59710c0865a01b9588d3be1e4177273ac into 25eb018f18a9a1d0865c16e5233a2a7ccddbfd78 - view on LGTM.com

new alerts:

  • 4 for Unused import

lgtm-com[bot] avatar Oct 15 '20 11:10 lgtm-com[bot]

Also, forgot to mention the docs. The CEM agent code didn't have docstrings afair.

sampreet-arthi avatar Oct 16 '20 19:10 sampreet-arthi

Also, forgot to mention the docs. The CEM agent code didn't have docstrings afair.

Yeah, I'll get that done too

hades-rp2010 avatar Oct 16 '20 19:10 hades-rp2010

This pull request introduces 2 alerts when merging f5a189d6f8fd35dade60b1573983b692382ef0f8 into 25eb018f18a9a1d0865c16e5233a2a7ccddbfd78 - view on LGTM.com

new alerts:

  • 2 for Unused import

lgtm-com[bot] avatar Oct 17 '20 21:10 lgtm-com[bot]

This pull request introduces 2 alerts when merging 4b11c16fd8b353e115fe7cded8db7c71f0d2f0eb into 25eb018f18a9a1d0865c16e5233a2a7ccddbfd78 - view on LGTM.com

new alerts:

  • 2 for Unused import

lgtm-com[bot] avatar Oct 21 '20 16:10 lgtm-com[bot]