genrl icon indicating copy to clipboard operation
genrl copied to clipboard

Add PyTorch Lightning support

Open sauradefy99 opened this issue 4 years ago • 8 comments

PyTorch Lightning automates away most of the engineering required on PyTorch for features like multi-GPU distributed training, early stopping, etc. More details can be found on the blog for the latest version here: https://medium.com/pytorch/pytorch-multi-gpu-metrics-and-more-in-pytorch-lightning-0-8-1-b7cadd04893e.

sauradefy99 avatar Jun 23 '20 13:06 sauradefy99

Any thoughts on how you're going to go about it? Not sure but I think we can use model parallelism but not data parallelism unless we have offline RL datasets (which we should add support for too)

Sharad24 avatar Jun 23 '20 17:06 Sharad24

@sauradefy99 Did you think on this? I think a good first step could be in trying out Offline RL?

Multi-GPU distributed training isn't the same at least in the online/off-policy case, it might be for Offline/Batch RL.

Sharad24 avatar Jul 18 '20 23:07 Sharad24

Reopen if you're working on it

Sharad24 avatar Aug 02 '20 06:08 Sharad24

I think this issue needs to be reopened. PLightning support should be critical

ugurkanates avatar Oct 18 '20 20:10 ugurkanates

Hey @ugurkanates , thanks for your interest in GenRL! We'd closed this initially because a lot of our team is working on some or the other thing right now. Would you be interested in helping us with this? Let us know if you can!

sampreet-arthi avatar Oct 20 '20 13:10 sampreet-arthi

Yes I'm actually looking forward because we are trying to integrate RL frameworks to our codebase and we still want benefits from PL Lightning to apply.

ugurkanates avatar Oct 20 '20 13:10 ugurkanates

Sounds great! I'll assign you to this then. Let us know how you're gonna go about this.

cc: @Sharad24

sampreet-arthi avatar Oct 20 '20 16:10 sampreet-arthi

Sorry but we instead decided to go with RLLib for now. Maybe later someone(or me) will keep updated on this task

ugurkanates avatar Oct 27 '20 11:10 ugurkanates