genrl icon indicating copy to clipboard operation
genrl copied to clipboard

Mujoco, PyBullet support

Open Sharad24 opened this issue 4 years ago • 12 comments

We should develop an environment module with wrappers. For a starter, I find TF Agents env module pretty good.

Sharad24 avatar May 19 '20 09:05 Sharad24

I'll work on Atari wrappers.

sampreet-arthi avatar May 19 '20 09:05 sampreet-arthi

Ok sure. I'm making a list of some that we should support at the very least, and some that we can think of adding.

Sharad24 avatar May 19 '20 09:05 Sharad24

  • [x] Atari (@Zeus3101 )
  • [ ] PyBullet
  • [ ] Mujoco
  • [x] Generic monitor, etc wrappers around gym (@Zeus3101 )

Sharad24 avatar May 19 '20 09:05 Sharad24

I'll do generic wrappers too if that's fine

sampreet-arthi avatar May 19 '20 22:05 sampreet-arthi

Sure. Just ensure they are compatible with vecenvs which we should also move under this module.

On Wed, 20 May 2020, 04:02 Sampreet, [email protected] wrote:

I'll do generic wrappers too if that's fine

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SforAiDl/genrl/issues/125#issuecomment-631120450, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ6IVWR5HFX5PRFE3ZLRSMCGDANCNFSM4NE2KDLQ .

Sharad24 avatar May 19 '20 23:05 Sharad24

Hmm... Okay. Should I also accommodate for classical models or only the deep models? Depending on that, I'll add a folder called wrappers (or) environments under genrl or genrl/deep.

sampreet-arthi avatar May 20 '20 12:05 sampreet-arthi

If you can, thats definitely better

Sharad24 avatar May 20 '20 15:05 Sharad24

Also, I think it would be a good idea to move VecEnv.py into this folder too. It makes more sense keeping it environments rather than in deep/common

sampreet-arthi avatar May 20 '20 15:05 sampreet-arthi

Yeah that makes sense.

On Wed, 20 May 2020, 21:15 Sampreet, [email protected] wrote:

Also, I think it would be a good idea to move VecEnv.py into this folder too. It makes more sense keeping it environments rather than in deep/common

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SforAiDl/genrl/issues/125#issuecomment-631558568, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH72FJ224FMLW523YDF67WDRSP3KJANCNFSM4NE2KDLQ .

Sharad24 avatar May 20 '20 17:05 Sharad24

Do we want pybullet and mujoco by v0.1?

sampreet-arthi avatar Jun 15 '20 17:06 sampreet-arthi

I think we should probably focus on getting what we have better structured first (internally) but let anyone else (not a core contributor) work on this.

Sharad24 avatar Jul 18 '20 23:07 Sharad24

Stale issue message

github-actions[bot] avatar Sep 19 '20 00:09 github-actions[bot]