Dominic Monroe

Results 171 comments of Dominic Monroe

I agree. We shouldn't be leaking implementation details there. Exceptions in Clojure are hard, we really don't have a great error handling methodology, especially for interop. The behavior is essentially...

This is due to https://dev.clojure.org/jira/browse/TNS-45 On May 4, 2018 6:55:46 PM GMT+01:00, deadghost wrote: >I used `tag` on my routes and now whenever I run `cider-refresh` and >visit a route,...

I'm a little bit confused. While trusting those headers is bad, bidi acts as a whitelist system, and that effectively prevents this doesn't it?

I think I see the problem. Bidi has its own concept of what the actual host is, and you're reading the host header directly elsewhere in your application (for what?)...

Ah, I hadn't considered those functionalities together. I don't think `:*` is very safe then. Specifying a host should alleviate this.

We were talking about nginx-clojure over lunch! How coincidental. Looks like there's some issues with running assoc/update over the map perhaps? https://github.com/juxt/bidi/blob/master/src/bidi/ring.clj#L39 Bidi doesn't do much to the request object,...

I see. That explains this behavior then. In my opinion, that does derive from the ring specification somewhat. I'm not sure bidi's ring handlers should be updated to accommodate derivations...

Depending on what you're trying to achieve, there's different solutions here. `js/location.hash` gives the result `"#/about-me"`, meaning that the solution is to do `(subs js/location.hash 1)` for the URL. However,...

Documentation may well be the best way to resolve this. We're having a focus on documentation at JUXT right now, so bidi may be a good candidate for improving as...

Url fragments aren't sent to the server, ever.