Enterprise icon indicating copy to clipboard operation
Enterprise copied to clipboard

Add support for pentoo live dvd

Open 0ff opened this issue 8 years ago • 7 comments

Please note that in order to actually make pentoo work, you will need to add isoboot=/efi/boot/boot.iso to the kernel cmdline!

Working enterprise.cfg (does not need this PR):

entry Pentoo
iso pentoo-amd64-hardened-2015.0_RC4.6.iso
initrd /isolinux/pentoo.igz
kernel /isolinux/pentoo root=/dev/ram0 init=/linuxrc nox nodhcp aufs max_loop=256 dokeymap looptype=squashfs loop=/image.squashfs cdroot video=uvesafb:mtrr:3,ywrap,1024x768-16 usbcore.autosuspend=1 console=tty0 net.ifnames=0 isoboot=/efi/boot/pentoo-amd64-hardened-2015.0_RC4.6.iso

0ff avatar Jun 27 '16 13:06 0ff

@0ff Is it possible to make this generic by targeting Gentoo instead, and then get support for Pentoo and other derivatives for free?

EDIT: Also, it appears that there has not been a release of this distribution for some time.

SevenBits avatar Jun 27 '16 16:06 SevenBits

Hm, I thought about it (saw that you've dropped Mint for the same reason). Some kind of inheritance maybe, where one could say family Gentoo/Pentoo and it'd resolve up the path and inherit what's not overridden (such as the addt'l boot param isoboot)? Might also be useful to get the iso-scan/filename param for Debian/Ubuntu out of grub.cfg :)

0ff avatar Jun 27 '16 16:06 0ff

I know that distributions such as Ubuntu tend to have derivatives that follow the same basic pattern, so you can have one set of commands boot pretty much every distribution based on Ubuntu out there. I use this in Mac Linux USB Loader to get support for lots of popular distributions without having to do much work.

Might also be useful to get the iso-scan/filename param for Debian/Ubuntu out of grub.cfg :)

Sorry, what do you mean here? Nevermind, was being stupid. Yes, that seems like a good idea.

Also, checking online, it seems that Pentoo has not had a stable release since 2012. Is there a active user base on this? I don't want to support novelty distributions without many users behind them, those guys can always boot their ISOs manually, without support hard-coded into Enterprise.

SevenBits avatar Jun 27 '16 16:06 SevenBits

Yes, the idea is clear, was just thinking about the implementation.

As for the grub.cfg - here https://github.com/SevenBits/Enterprise/blob/master/grub.cfg#L42 you always append iso-scan/filename=${iso_path} to the kernel - this parameter is not known in gentoo for example.

Well to be honest, I'm not sure about the userbase of pentoo, all I know is they provide a gnuradio live-dvd, that's what I wanted ;) Get your point though, so maybe don't add support for Pentoo then :) To be honest - you'd need the kernel-line anyways so this PR is not that useful in itself.

0ff avatar Jun 27 '16 16:06 0ff

you always append iso-scan/filename=${iso_path} to the kernel - this parameter is not known in gentoo for example.

Yes, sorry, now I understand what you were saying. This is a legacy from back when I only supported Ubuntu. It hasn't broken anything yet so I've had little reason to change it, but, you're right -- this should ideally be changed.

Get your point though, so maybe don't add support for Pentoo then :) To be honest - you'd need the kernel-line anyways so this PR is not that useful in itself.

Well, I'm not opposed to merging this PR, I mean if it's a useful distribution then fine, I'm just wondering as to whether or not it's worth it, since if it's in the source code I kind of have to support it and keep it up to date, you know?

Also, nice catch with the config file -- I didn't realize that I'd forgotten to include it. Out of curiosity, how'd you get the config file out of the GRUB image?

SevenBits avatar Jun 27 '16 16:06 SevenBits

Understood, as I said - I don't know about the usage. It might grow now that SDRs are all the rage. That's what got me onboard anyway.

Oh the cfg, I saw your GRUB Readme and realized you've embedded the cfg in the boot.efi. From there it was just opening my hex editor of choice and exporting it (it's at the very end just before the memdisk): screen shot 2016-06-27 at 18 41 29

0ff avatar Jun 27 '16 16:06 0ff

@0ff Ah, I see. Well, thanks for catching my oversight. :+1:

As to this PR, I'll look more into this distribution and the story behind it, and I'll make a decision on whether or not to merge. In the meantime, feel free to contribute to Enterprise in other ways as well -- there's a long list of improvements I'd like to make!

SevenBits avatar Jun 27 '16 16:06 SevenBits