SyliusPickupPointPlugin icon indicating copy to clipboard operation
SyliusPickupPointPlugin copied to clipboard

Remove the cached provider functionality

Open loevgaard opened this issue 2 years ago • 1 comments

Fixes https://github.com/Setono/SyliusPickupPointPlugin/issues/76

This functionality is only used when a user goes the shipping page then goes to some other page and ends up on the shipping page again. I reckon all this complexity is not necessary for such a small case.

Wdyt @vvasiloi?

loevgaard avatar Jan 09 '23 08:01 loevgaard

Codecov Report

Base: 14.55% // Head: 14.37% // Decreases project coverage by -0.17% :warning:

Coverage data is based on head (9de6028) compared to base (43146ee). Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x      #99      +/-   ##
============================================
- Coverage     14.55%   14.37%   -0.18%     
+ Complexity      241      223      -18     
============================================
  Files            37       36       -1     
  Lines           852      765      -87     
============================================
- Hits            124      110      -14     
+ Misses          728      655      -73     
Impacted Files Coverage Δ
...ndencyInjection/Compiler/RegisterProvidersPass.php 0.00% <ø> (ø)
src/DependencyInjection/Configuration.php 100.00% <ø> (ø)
...encyInjection/SetonoSyliusPickupPointExtension.php 50.00% <ø> (+3.12%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 09 '23 08:01 codecov[bot]