SyliusGiftCardPlugin icon indicating copy to clipboard operation
SyliusGiftCardPlugin copied to clipboard

Published 20 hours ago • verified publisher icon Setono

List of Orders payed with GiftCard

Open igormukhingmailcom opened this issue 5 years ago • 2 comments

If balances not equal (so gift card used) - ability to click on Used at orders link/button and see page with Orders list where this GiftCard was used.

  • [x] For admin
  • [ ] For customer?

igormukhingmailcom avatar Nov 13 '19 11:11 igormukhingmailcom

I'm trying to display the list of orders, but I have this error: "Argument 1 passed to App\Repository\OrderRepository::createCompletedQueryBuilderByGiftCard() must be of the type string, object given" It is an implementation error or a known error ?

Shoud I try to override this request to fix it ?

sahnhi avatar Dec 09 '20 17:12 sahnhi

Thanks for reporting, @sahnhi

https://github.com/Setono/SyliusGiftCardPlugin/commit/e80c1783421b3237df7484a6ff2802ea7d7781fb#diff-b6158aa28c380775c04f4a5a6e2ceb57802addf71ca99777287cefa67de1d7e9L10

I guess we need

giftCardId: $id

rather than

giftCard: $id

This should fix the issue.

@sahnhi, don't you mind to try that and make PR if this fix will work?

igormukhingmailcom avatar Dec 10 '20 12:12 igormukhingmailcom