Seth Tisue

Results 1957 comments of Seth Tisue

Community build results will improve our confidence this won't produce false positives.

@dwijnand is this something you want to look at, or something it would make sense for you and I to look at together?

Jason [describes](https://github.com/scala/scala/pull/9372#issuecomment-741581714) his approach: > I defer the fruitless type test check for patterns until the patmat phase and also introduce a stronger analysis that checks that if the scrutinee...

@jxnu-liguobin I see that this is already passing CI. So first, what in your view on the status of the test cases in the PR. Do they seem right to...

Ah, I understand better now: * scala/bug#12304 wasn't a bug * Jason's code aims to fix something else, which I've made a new ticket on: scala/bug#12438

@jxnu-liguobin can you explain where this stands currently? do your recent changes resolve the concerns that were raised earlier, and if so how?

@martijnhoekstra I saw you commented on the ticket. Do you feel able to review these changes? (This isn't code I'm familiar with, and Dale is busy with other things.)

@lrytz perhaps you could step in here? this is over my head...

paging @dwijnand — would you like to look at this together during one of our pairing sessions?