proton icon indicating copy to clipboard operation
proton copied to clipboard

Fixes for scroll wheel in ScrollComponent

Open mar4ello6 opened this issue 1 year ago • 2 comments

Now, the scroll wheel will only scroll in the entity where the cursor is located. Before, it scrolled every Entity with ScrollComponent existing. The scroll bar now also recognizes the scroll wheel.

mar4ello6 avatar Sep 28 '23 22:09 mar4ello6

I disagree with using Windows APIs directly within Proton, even if it's behind an ifdef-guard. I'd use extern variables or functions to get the x/y position of the cursor, and hook WM_MOUSEMOVE to update it.

I don't see why the scroll bar didn't fade in when scrolling. This is a good change.

iProgramMC avatar Nov 19 '23 18:11 iProgramMC

Appreciate the patch (sorry for the delay) - won't merge right now though, some things have changed since this was written (I added/changed some scroll wheel stuff so my SlideShow project could zoom in/out, it it may need to be tweaked to use that, hope to take a closer look later

SethRobinson avatar Mar 26 '24 08:03 SethRobinson