Seth Falco

Results 325 comments of Seth Falco

It looks like when using GitHub Actions, there's actually no need to even go through a bot user. 🤔 ![](https://user-images.githubusercontent.com/22801583/134893502-d7f02f30-85ac-4402-a58c-bb64c62d92e1.png) We can make the pipeline approve or request changes on...

```yaml name: free-programming-books-lint on: [push, pull_request] jobs: build: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Use Node.js uses: actions/setup-node@v1 with: node-version: '14.x' - run: | git clone https://github.com/SethFalco/free-programming-books-lint.git cd...

> Can we have this working well before Friday? I think so, the only flaw I've found is that it can be spammy if someone does many small commits. For...

> failed to create review: Resource not accessible by integration I'm assuming that's because of the repository settings. ~~@eshellman Sorry to pester, could you please peek at the settings: https://github.com/EbookFoundation/free-programming-books/settings/actions~~...

Actually… GitHub just tried to run my new workflow in the PR for the new workflow? (Actually that makes sense, but RIP.) Maybe this is a bad idea, actually. 🤔...

I'm thinking about coming back to this one later, but first I'd like https://github.com/vhf/free-programming-books-lint/pull/29 to be resolved. 🤔 I think there was a discussion before about some of the linter...

GitHub made a new feature which might make this cleaner: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ It doesn't post a comment though, but rather than post a comment here we could use the summary feature...

@kaeleyworks I can see you're interested in [freeCodeCamp](https://github.com/freeCodeCamp/freeCodeCamp), so asking in the forum would be more appropriate and yield much better answers. https://forum.freecodecamp.org/ I don't think this issue is the...

I've just tested this and found that negative lookaheads appear to be working fine. I'm using Ubuntu 18.04, Firefox 85.0.1 (64-bit). I tested this page with `Negative(?![ (])` which failed...

> I'm not certain if this is the real solution, but should anyone else have any problems with the add-on, they can try this solution. I can vouch that it...