set-protocol-v2
set-protocol-v2 copied to clipboard
fix(notional): Fix contract name and bytecode shadowing issues for temp Notional contracts
DO NOT MERGE.
(These are small adjustments to get a NotionalTradeModule staging deployment working, published at the notional
tag as version 0.11.1-notional. (See deployments-v2 PR 208). They affect contracts that will be removed when IC returns to finalize the NotionalTradeModule after audit)
As part of #251, several contracts that will be published/deployed by Notional in future have been temporarily brought into the repo to enable NotionalTradeModule development and staging_mainnet testing
Unfortunately the way these contracts are imported results in duplicate hardhat artifacts being generated and two problems in the downstream deployments repo:
- hardhat-etherscan errors with a complaint that it cannot disambiguate between the contract bytecodes for verification
- hardhat-deploy errors with a complaint that it cannot locate the contract for deployment (when contract names shadow each other)
This PR renames WrappedfCashFactory root-level contract and makes other Notional contract bytecodes slightly different (in an irrelevant way) to get around these.
Note that https://github.com/SetProtocol/set-protocol-v2/pull/256 will remove these temporarily added contracts and should thereby fix these issues.