Jon Stovell

Results 132 comments of Jon Stovell

My comment [here](https://github.com/SimpleMachines/SMF/pull/7516#issuecomment-1217173908) also applies to this PR, I'm afraid. 🙁

See https://github.com/SimpleMachines/SMF/pull/7516#issuecomment-1218200073 🙂

I'm fine with changing the milestone, so long as no actual database changes will be required to fix this.

My comment [here](https://github.com/SimpleMachines/SMF/pull/7516#issuecomment-1217173908) also applies to this PR, I'm afraid. 🙁

See https://github.com/SimpleMachines/SMF/pull/7516#issuecomment-1218200073 🙂

Why the change to `content_type` for unapproved replies? I agree that it would make better sense for it to be `msg` rather than `topic` in such cases, but changing this...

I ask because I'd rather not force the translators to redo the $txt string if we can avoid it.

You make a good case for doing this by the time we finish the final version of 2.1.

> We could also remove it entirely. I think in nearly all cases, folks are going from TEXT to MEDIUMTEXT, not the other way around. In this example, user was...