Jon Stovell

Results 132 comments of Jon Stovell

> Maybe #8226 fixed this too? Maybe. At any rate, it seems that we can close this.

Hm. I just noticed a few places in some of the older upgrade files where `addslashes()` appears to be used to escape SQL strings. Even without the changes in this...

Note: This PR targets release-2.1, but it has been assigned to the milestones for SMF 3.0. The PR will need to be updated and resubmitted to target release-3.0. I am...

This pull request targets release-2.1, so it doesn't belong in the 3.0 milestone, and we aren't going to make this change now in the 2.1 upgrader. That said, if a...

Note: This PR targets release-2.1, but it has been assigned to the milestones for SMF 3.0. The PR will need to be updated and resubmitted to target release-3.0. I am...

Between being still sick and now having to rebuild my dev machine (ugh), I'm asking @BrickOzp to review this.

I cannot reproduce this myself. @dragomano, does the issue still exist for you? Perhaps more recent changes have solved it already, but I don't know.

Several of my own. Can you give me a mod that does produce the error? Then I can figure out what is causing it.

It's too late to make this change in the 2.1. However, if a new PR implementing these changes and the ones in #6208 is submitted for release-3.0, that would be...