Fix: Superfluous response.WriteHeader call in otelhttp

Open felipeweb opened this issue 1 year ago • 1 comments

This PR updates the OpenTelemetry packages to address the http: superfluous response.WriteHeader call error originating from go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp/internal/request.(*RespWriterWrapper).writeHeader.

This issue is resolved in the updated OpenTelemetry version, as confirmed by the corresponding pull request in the OpenTelemetry repository: https://github.com/open-telemetry/opentelemetry-go-contrib/pull/6055.

This update ensures accurate HTTP response handling and eliminates the error message.

Oct 18 '24 02:10 felipeweb

@felipeweb, thanks for your PR. However, your go.mod changes are quite intrusive.

Do you have an example to reproduce this issue when using weaver?

Thanks,

Robert

Nov 05 '24 23:11 rgrandl