weaver icon indicating copy to clipboard operation
weaver copied to clipboard

Published 20 hours ago • verified publisher icon ServiceWeaver

fix crash when failed to open Perfetto database on DashboardCommand()

Open ymmuse opened this issue 2 years ago • 3 comments

This PR fixs crash when failed to open the TraceDB. From the current execution flow of the code, it seems that the failure to open TraceDB will not interrupt the start of the Dashboard service, so the start of the Trace service is placed in the else branch.

ymmuse avatar Mar 08 '23 02:03 ymmuse

Mind rebasing onto main and resolving any conflicts? Then, I'll merge the PR!

mwhittaker avatar Mar 10 '23 18:03 mwhittaker

Hi @mwhittaker , I have resolved the conflicts.

ymmuse avatar Mar 13 '23 04:03 ymmuse

Hey @ymmuse, GitHub is still not letting me merge because of conflicts. I recommend pulling the latest main and then running something like git rebase --onto main {c4d119b69258932be0365f5551aa63c9a83e164b,~} to rebase your commit on top of main. Then update the dashboard branch and force push.

mwhittaker avatar Mar 13 '23 16:03 mwhittaker

Hi @mwhittaker, I make a new PR(#158 ) based on top of main.

ymmuse avatar Mar 14 '23 02:03 ymmuse