weaver icon indicating copy to clipboard operation
weaver copied to clipboard

update gitignore

Open charles-chenzz opened this issue 2 years ago • 1 comments

update gitignore to prevent new contributors push IDE files to main branch

charles-chenzz avatar Mar 05 '23 07:03 charles-chenzz

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 05 '23 07:03 google-cla[bot]

sorry for the ping, but can you help me reviewing my PR? @spetrovic77

charles-chenzz avatar Mar 06 '23 06:03 charles-chenzz

Thanks for your patience, I was trying to check what is the best policy here.

According to this Stack Overflow answer, it seems the best policy for the project is to keep the project's .gitignore contain only files that are applicable to the project (e.g., project's compiled binares). And then every user will create their own $HOME/.gitignore which contains their IDE and OS files:

I'm inclined to agree with the post, so will provisionally close this issue but feel free to open if you strongly disagree.

spetrovic77 avatar Mar 06 '23 17:03 spetrovic77

Forgot to include the link:

https://stackoverflow.com/questions/61982834/what-should-contain-gitignore-file-when-is-a-public-repository

spetrovic77 avatar Mar 06 '23 17:03 spetrovic77

sure,it's fine just want to help and make sure something, but the stack overflow answer did make sense, it should be you to set up the rules in this repo and we try to help and see

charles-chenzz avatar Mar 07 '23 01:03 charles-chenzz