skin.auramod icon indicating copy to clipboard operation
skin.auramod copied to clipboard

HDR logo - Enhancement?

Open JFG1000 opened this issue 3 years ago • 7 comments

20220112_224530

Would it be atall possible to add a HDR logo to the area drawn in the photo which will display when selecting HDR files?

JFG1000 avatar Jan 12 '22 22:01 JFG1000

Show a example of a skin or default skin where this work's

SerpentDrago avatar Jan 13 '22 03:01 SerpentDrago

20220113_133245

My apologies, I didn't realise it may not be possible, when i just see it being used in this source select screen I imagined it may have been possible to add

JFG1000 avatar Jan 13 '22 13:01 JFG1000

The add-on is parseing in Python The actual torrent filename to display that info(txt string .HDR. )The player/skin doesn't always have access to that filename or have The ability to parse a string value from that text. It would have to be meta info passed from addon to skin or officially supported in Kodi. though a list item variable.

If you can find a example in a skins player osd that displays it . That would work with all add-ons. Then that would allow us to see how to do it.

SerpentDrago avatar Jan 13 '22 21:01 SerpentDrago

Fair enough mate, not sure if it can be done then, I've never noticed it on any other skin.

JFG1000 avatar Jan 14 '22 06:01 JFG1000

It's possible but you'd have to rename EVERY media file and add in the media info tags.


https://forum.kodi.tv/showthread.php?tid=351883 Looks like this guy puts the media info in the filename and AEON MQ displays it.


Here's a skin that, looks like, implements this.: https://github.com/b-jesch/skin.estuary.modv2

Here's the skin player osd:

screenshot_4

Another:

screenshot_6


File name flagging

If you want to use special flags like HDR or Dolby Vision or special 3D formats you have to name your files with proper tags, preferably before the file extension:

3D with
stereoscopic detection
MVC codec Side by Side Top and Bottom HDR Files HDR+ Files Dolby Vision
no tagging or 3d 3d.mvc 3d.sbs 3d.tab .hdr., .10bit. .hdrplus., .12bit. .dv., .dovi., .dolbyvision.

The HDR type recognition by filename will be removed if Kodi detects the HDR type itself properly.


jojobrogess avatar Jan 14 '22 20:01 jojobrogess

I installed that skin, seems to work for my files. I don't have any 4k movies/shows though or HDR.

2022-02-20 22_42_44-Greenshot

2022-02-20 22_44_50-Greenshot

2022-02-20 22_45_21-Greenshot

very interesting skin btw, the disc with the discart on it in the last photo was spinning... It also stops spinning if you pause the video.

2022-02-20 22_48_24-Greenshot

Hovering over settings icon on main menu shows this:

2022-02-20 22_49_43-Greenshot

jojobrogess avatar Feb 21 '22 07:02 jojobrogess

Just did a little research on this, it look like they added the ability to "Detect, store and process the type of HDR in a video file" in PR #19983

screenshot00106

I don't know how this works yet, but I would assume this would take a lot more work than it looks like. You have to decompile the textures, add new images for HDR and add code to reference it, and then recompile the textures.

If anyone has an HDR image pack that looks like it would match the flags we already use, please post a link to the images themselves or post them here

Here are the ones we are using atm: Color: 2160 4k 288 480 540 576 720 1080 2160

Videotype: 3d 4k bluray dvd fps hdr hdtv web-dl

Channels: 0 1 2 3 4 5 6 7 8 10

Monochrome: 4k 288 480 540 576 720 1080 2160 VideoType: 3d 4k bluray dvd fps hddvd hdr hdtv web-dl Channels: 0 1 2 3 4 5 6 7 8 10

jojobrogess avatar Jan 09 '23 21:01 jojobrogess