ErrorProne.NET icon indicating copy to clipboard operation
ErrorProne.NET copied to clipboard

Not clear how to install and execute ErrorProne.NET on user's c# solution

Open constructor-igor opened this issue 8 years ago • 10 comments

constructor-igor avatar Apr 06 '16 07:04 constructor-igor

Sorry for late response: just add package via nuget - https://www.nuget.org/packages/ErrorProne.NET/

SergeyTeplyakov avatar May 26 '16 03:05 SergeyTeplyakov

Do you like me for execute same trick as for ExceptionAnalyzer to setup appveyor build for this? :-)

leotsarev avatar Apr 24 '18 20:04 leotsarev

It'll be great!

SergeyTeplyakov avatar Apr 24 '18 20:04 SergeyTeplyakov

Just to be clear: if I do this, will you setup & publish public nuget builds? :-)

leotsarev avatar Apr 24 '18 20:04 leotsarev

Absolutely!

SergeyTeplyakov avatar Apr 24 '18 23:04 SergeyTeplyakov

nugets & shared library problem. StructAnalyzer depends on ErrorProne.Net.Core and it will manifests as package depedency. I can package ErrorProne.Net.Core as separate package, but it could lead to conflicts if different versions of ErrorProne.XXX is installed and they require different versions of Core. It could be solved by binding redirects and carefully watching backward compatibility.

Another approach (that I'll try to pursue in my PR) is to ILMerge Core into ErrorProne.XXX during build, so it will have no dependencies.

Feel free to express you preference or correct me if my post is wrong.

leotsarev avatar Apr 25 '18 10:04 leotsarev

@leotsarev Hm... I thought that there should be a better way to handle the situation but these two:(

The first concern is actually valid because the plan is to have more than one analyzer. It means that a person could have ErrorProne.NET.Memory analyzer version 1 but ErrorProne.NET.Structs version 2.

I'm ok with the ILMerge approach, but I'll take a look at other options.

SergeyTeplyakov avatar Apr 25 '18 20:04 SergeyTeplyakov

Another idea: make helpers a bunch of cs files directly included to.other projects.

leotsarev avatar Apr 26 '18 18:04 leotsarev

And what about the solution from #50?

SergeyTeplyakov avatar Apr 27 '18 23:04 SergeyTeplyakov

@SergeyTeplyakov seems that nothing prevents you to start publishing ErrorProne.Net.Exceptions builds. If there is something could be contributed from my side, please say :-)

leotsarev avatar Aug 27 '18 07:08 leotsarev