Sergey Kopienko comments

Results 44 comments of


                                            Sergey Kopienko

SYCL Rewrites of inclusive_scan_by_segment, exclusive_scan_by_segment, and reduce_by_segment

@mmichel11 I think required to update this branch from current main branch state.

[BUG] oneapi::dpl::reduce_by_key cannot produce expected output

Fine! Thank you, @lilohuang!

Adding transform_if algorithm and tests

@danhoeflinger is it possible to fix clang format here as part of our common process? Or current format is ok?

reduce_by_segment compilation failure for non-primitive types

@upsj, this issue were already fixed in https://github.com/oneapi-src/oneDPL/pull/505 Could you please confirm that now all is OK ? P.S. sorry for delay.

reduce_by_segment compilation failure for non-primitive types

@upsj, this issue were fixed in https://github.com/oneapi-src/oneDPL/pull/505 Thank you for info.

Do not use internal API in the tests

@akukanov, @dmitriy-sobolev but what about https://github.com/oneapi-src/oneDPL/pull/937 ? I mean `__dpl_sycl::__get_host_access` in the tests. Looks like it should be fixed too. I the tests for permutation iterator I just copied data...

Enable gcd and lcm tests on Windows since L0 backend issue is fixed

@haonanya could you please explain and describe in this PR the goal of this changes?

reopen #514 : in-place exclusive scan

@zjin-lcf FYI: this issue were fixed in https://github.com/oneapi-src/oneDPL/pull/761 Could you please check and confirm that now you have correct work of in-place exclusive scan algorithm?

reopen #514 : in-place exclusive scan

You are welcome!

Multiple backends prototype

@akukanov If this approach looks ok we may try to extend it for hetero backends too,