serenity icon indicating copy to clipboard operation
serenity copied to clipboard

LibGfx/GIF: Correctly write frames with a non-null position

Open LucasChollet opened this issue 1 year ago • 3 comments

Fix #24411

LucasChollet avatar May 22 '24 21:05 LucasChollet

Sure, you'll have to wait until tomorrow for that tho

LucasChollet avatar May 22 '24 22:05 LucasChollet

see webp animation test for an example

This was the worst advice you could give me. I copied some parts of it, including this line, which has a behavior that isn't really intuitive: rgb_bitmap_2->scanline(3)[3] = Color::Red; (hint: type of the lhs is ARGB aka int)

Fun fact: for some reason that I don't understand, the WebP test fails if you write a color with an alpha value equal to 255, but pass otherwise. I'll let you fix this one. See #24428

LucasChollet avatar May 24 '24 02:05 LucasChollet

#24433

nico avatar May 24 '24 13:05 nico