serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Base: Add more emoji

Open Xexxa opened this issue 1 year ago • 1 comments

🤽 - U+1F93D PERSON PLAYING WATER POLO 🤽‍♂️ - U+1F93D U+200D U+2642 MAN PLAYING WATER POLO 🤽‍♀️ - U+1F93D U+200D U+2640 WOMAN PLAYING WATER POLO 🦨 - U+1F9A8 SKUNK

For some reason: "Error! Emoji entry for U+1F93D_U+200D_U+2642.png not found. Please check emoji-file-list.txt." Not sure why.

Xexxa avatar Apr 30 '24 20:04 Xexxa

Hi @Xexxa , the new emoji are looking cute! In https://github.com/SerenityOS/serenity/pull/23643 (specifically, https://github.com/SerenityOS/serenity/commit/91cd43a7ac7dcddf3f8612929263f87b745162a6), Tim added a file that lists every single emoji file. This was needed to make sure that we could copy all of the files into the location needed to load the emojis from Ladybird, and to make sure to install only the files we need when installing Ladybird (e.g. for package managers and linux distributions).

So for this patch, you'll need to add a line item for each emoji file in Meta/emoji-file-list.txt

ADKaster avatar May 01 '24 08:05 ADKaster

Hi @Xexxa , the new emoji are looking cute! In #23643 (specifically, 91cd43a), Tim added a file that lists every single emoji file. This was needed to make sure that we could copy all of the files into the location needed to load the emojis from Ladybird, and to make sure to install only the files we need when installing Ladybird (e.g. for package managers and linux distributions).

So for this patch, you'll need to add a line item for each emoji file in Meta/emoji-file-list.txt

Thanks a lot for the explanation ADKaster, I read the error message("Please check emoji-file-list.txt.") as "Please check emoji-serenity.txt" and was very confused because these are RGI emoji. When expecting one thing and are not focused enough the mind might draw it's own conclusions :-D

Xexxa avatar May 11 '24 18:05 Xexxa