serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Make things build on i386-gnu again

Open bugaevc opened this issue 1 year ago • 4 comments

cc:

  • @spholz and @BertalanD for the LibELF change
  • @nico for LibPDF & JBIG2
  • @ADKaster for Core::MachPort
  • @stelar7 for LibCrypto / MGF

bugaevc avatar Apr 24 '24 14:04 bugaevc

Visual proof that things still work:

Screenshot from 2024-04-24 17-21-05

bugaevc avatar Apr 24 '24 14:04 bugaevc

Error: An error occurred trying to start process '/usr/bin/bash' with working directory '/home/runner/work/serenity/serenity/Build/x86_64'. No such file or directory

That's clearly not my fault?

bugaevc avatar Apr 24 '24 14:04 bugaevc

Pushed a fix for aarch64-gnu.

By the way, please feel free to cherry-pick individual patches, they should be independent from each other.

bugaevc avatar Apr 25 '24 12:04 bugaevc

I think LibELF changes are not required anymore after (merged) #24105. We don't build these files on lagom now.

DanShaders avatar Apr 28 '24 17:04 DanShaders

I think LibELF changes are not required anymore after (merged) #24105. We don't build these files on lagom now.

It built fine without the ELF changes indeed, thanks!

bugaevc avatar May 02 '24 11:05 bugaevc