serenity icon indicating copy to clipboard operation
serenity copied to clipboard

LibWeb: Ensure non-negative inner_bounding_rect dimensions

Open SuntzuDragon opened this issue 10 months ago • 3 comments

Another student project here! Add checks to prevent negative width and height in inner_bounding_rect within get_outer_box_shadow_configuration. This fixes issues with shadow corner swapping due to incorrect bounding box dimensions.

Fixes part of: https://github.com/SerenityOS/serenity/issues/23937

SuntzuDragon avatar Apr 19 '24 23:04 SuntzuDragon

Hi, this is failing a test: https://dev.azure.com/SerenityOS/SerenityOS/_build/results?buildId=46601&view=logs&j=2351e412-c793-598f-27f8-72c4f2d55ba1&t=ee375dfa-6b7d-514a-7789-3948d04c0dd3&l=2278

That's actually to be expected though. Please check that the test looks right, and then run the rebaseline script in Tests/LibWeb, passing the test's file path, to update the expectation. Then add that into your existing commit.

AtkinsSJ avatar Apr 21 '24 11:04 AtkinsSJ

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Apr 21 '24 21:04 BuggieBot

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar May 22 '24 00:05 stale[bot]

Sorry this has sat around a while! The code looks good, but there are a couple of problems with the commits:

  • LibWeb: Shadow box corner radii not correct should say what you did, in the imperative (like an instruction): something like LibWeb: Use correct formula for shadow corner radii.
  • That same commit's message needs to be wrapped at 72 characters.
  • The merge commits need to be removed.

Depending on how familiar you are with git, modifying existing commits can be a bit daunting. But it's not too complicated! See this video, and then you can always ask here or in Discord for some help if you get confused.

AtkinsSJ avatar May 26 '24 14:05 AtkinsSJ

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Jun 16 '24 20:06 stale[bot]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

stale[bot] avatar Jun 26 '24 17:06 stale[bot]