serenity icon indicating copy to clipboard operation
serenity copied to clipboard

LibWeb: Pass certificates to WebDriver and update WPT Metadata

Open ADKaster opened this issue 2 years ago • 1 comments

It's a bit awkward to pass these as --webdriver-arg, but that's life.

Perhaps we should do this in the ladybird.py script 🤷

ADKaster avatar Feb 13 '24 19:02 ADKaster

Funny thing about the metadata: If I run this as-is on this branch, two tests fail to meet the expectations:

  ▶ PASS [expected CRASH] /css/CSS2/floats/floats-rule3-outside-left-002.xht

  ▶ FAIL [expected CRASH] /css/CSS2/floats/floats-wrap-top-below-bfc-003r.xht
  └   → /css/CSS2/floats/floats-wrap-top-below-bfc-003r.xht ['e9154e0ba1bb7f5dcad48f4dd9c9be27b2c0818f']
/css/CSS2/floats/floats-wrap-top-below-003r-ref.xht ['2935fd3337df7b13926562548eb3f6fe632ef86f']

However, if I then run the --update-metadata flag to run.sh and re-run, then these tests actually 'crash' instead.

It seems like something about the behavior of the test driver when a test is expected to fail or to run successfully changes whether these tests pass or fail 🙃 .

ADKaster avatar Feb 13 '24 19:02 ADKaster