serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Published 20 hours ago • verified publisher icon SerenityOS

Utilities: Add xxd utility

Open Ollrogge opened this issue 1 year ago • 5 comments

Initial implementation of xxd. Some things are missing such as:

  • patching a hexdump into a binary
  • colorized output
  • seeking relative to current stdin offset
  • EBCDIC encoding (left this out since I don't think it is needed)

~~Pr depends on #22754~~

Ollrogge avatar Jan 17 '24 17:01 Ollrogge

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Feb 09 '24 06:02 stale[bot]

Not stale :/

Ollrogge avatar Feb 09 '24 08:02 Ollrogge

From my point of view it would be better to open a separate PR for the changes in commit: LibCore: Refactor template definitions to header in ArgsParser so those changes could be discussed separately from the xxd utility.

kennethmyhra avatar Feb 09 '24 09:02 kennethmyhra

From my point of view it would be better to open a separate PR for the changes in commit: LibCore: Refactor template definitions to header in ArgsParser so those changes could be discussed separately from the xxd utility.

That actually already happened and has been merged. Somehow it didn't cause a conflict. But rebasing on master would make that clearer.

AtkinsSJ avatar Feb 09 '24 10:02 AtkinsSJ

That actually already happened and has been merged. Somehow it didn't cause a conflict. But rebasing on master would make that clearer.

Ah, you're right. I looked for conflicts, but didn't check the linked PR

kennethmyhra avatar Feb 09 '24 10:02 kennethmyhra