serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Meta: Improve portability with compat for non-GNU, non-sudo systems

Open sdomi opened this issue 1 year ago • 2 comments

This MR fixes the build scripts on Alpine w/o coreutils (and other distros without GNU and sudo :p)

Firstly, we depend on GNU-specific du switch --apparent-size. Busybox has this implemented, but as -b instead.

Secondly, there's now logic to detect if your system has doas instead of sudo. If the user has neither, we bail out quickly instead.

sdomi avatar Jul 08 '23 04:07 sdomi

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Jul 08 '23 04:07 BuggieBot

Improving and unifying the remaining dependency checks is something I may tackle on a later rainy day :p

sdomi avatar Jul 08 '23 05:07 sdomi