serenity icon indicating copy to clipboard operation
serenity copied to clipboard

CI: redundant packages listed in gh workflows

Open volovikariel opened this issue 1 year ago • 0 comments

I believe we are currently installing some redundant packages in two of our github workflows (cmake.yml, and sonar-cloud-static-analysis.yml). I'll only list what I've spotted in cmake.yml, if these changes sound good, I'll make similar changes for sonar-cloud-static-analysis.yml in the PR.

In cmake.yml:

  1. We install g++-12, which depends on gcc-12 and libstdc++-12-dev
  2. We install libmpc-dev, which depends on libmpfr-dev

Additionally, it seems like the ubuntu-22.04 runner has g++-12 installed by default as of November 24, 2022.

Is it thus safe to remove g++-12, gcc-12, libstdc++-12-dev, and libmpfr-dev from the list of packages to install? I tested it in my own fork of the repository and everything seemed fine. Here is the diff from master.

Also, I'm wondering what's going on with the qemu-system-i386 package. I don't see it listed in the package repository for ubuntu-22.04, how are we installing it?

volovikariel avatar Jul 06 '23 17:07 volovikariel