serenity
serenity copied to clipboard
SerenityOS
Ports: Add cbonsai port
This PR modifies the port list and adds the package.sh script for cbonsai, a delightful program that generates bonsai trees in your terminal.
Hello!
One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.
Fixing the table row, sorry. Next time, I'll remember to run the lint script.
Edit: fixed.
The package.sh script isn't marked as executable. I think you need to chmod +x it.
After trying it out, I get crashes in strtold() when trying to provide any of the command-line arguments. :grimacing: It fails assert(sizeof(double) == sizeof(long double));
(This is a problem with libc, not with your PR, but it is annoying...)
Huh. The file was marked as executable, but Git marked it as 644 anyways. Just ran git update-index --chmod=+x and now it has registered.
Looks like it still managed to not be executable. (https://github.com/SerenityOS/serenity/pull/19622) :thonk: Maybe something about your system is messing with it. Are you on Windows?
Nope, I’m running Ubuntu. I ran git ls-files -s package.sh before updating the commit and it displayed 744 in the file perms. I have no idea what’s going on.