serenity icon indicating copy to clipboard operation
serenity copied to clipboard

sort: Allow sorting of arbitrarily long lines

Open tcl3 opened this issue 1 year ago • 1 comments

With this PR sort can now handle arbitrarily long lines. Previously, lines would be truncated at 4096 bytes.

My implementation of this feature avoids string allocations when building Line objects.

I have also replaced all remaining usages of DeprecatedString with StringView

Tested with lines up to 1MB.

tcl3 avatar Mar 19 '23 20:03 tcl3

I'm going to mark this as a draft, while I investigate the best way to process files one line at a time.

tcl3 avatar Mar 22 '23 17:03 tcl3