serenity icon indicating copy to clipboard operation
serenity copied to clipboard

CI: Ensure the manpage generation step shuts down the VM on failure

Open trflynn89 opened this issue 3 years ago • 1 comments

Currently, if the script fails, it simply runs "exit 1". This exits the script, but keeps the VM running, so CI hangs until it times out.

Instead of exiting, write a failure status to an error log and shutdown. CI can then read that error log and fail the run if needed.

trflynn89 avatar Oct 31 '22 16:10 trflynn89

Draft for now - I have a fix for the issue causing this failure, but want to make sure this script change actually makes CI fail instead of hanging for 10 minutes.

trflynn89 avatar Oct 31 '22 16:10 trflynn89

Should be good to go, we now fail CI instead of hanging when generate_manpages.sh fails

trflynn89 avatar Oct 31 '22 19:10 trflynn89