serenity icon indicating copy to clipboard operation
serenity copied to clipboard
verified publisher icon SerenityOS

Userland: Ignore super key press when in KeyboardMapper

Open huttongrabiel opened this issue 3 years ago • 1 comments

Stops KeyboardMapper from opening up the pop up when testing keys. This allows the super key to be pressed and show up without un-focusing KeyboardMapper.

To do so, m_should_ignore_super_key has been added as a window property. This allows any window to call window->set_ignore_super_key(true), and the super key will be ignored.

huttongrabiel avatar Oct 22 '22 20:10 huttongrabiel

But what happens for other keybindings?

demostanis avatar Oct 23 '22 07:10 demostanis

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Nov 25 '22 02:11 stale[bot]

I don't think that this PR as implemented is a scalable or complete solution to the problem of all not keypresses being sent to KeyboardMapper. Have a look at some discussion we had today in #userland on discord: https://discord.com/channels/830522505605283862/830526926569209917/1045808848293871676

ADKaster avatar Nov 25 '22 21:11 ADKaster

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Dec 16 '22 23:12 stale[bot]