serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Base: Added manpages for which(1) and stat(1)

Open jahway603 opened this issue 2 years ago • 11 comments

Added manpages for which(1) and stat(1)

jahway603 avatar Oct 22 '22 01:10 jahway603

Added manpages for Issue https://github.com/SerenityOS/serenity/issues/11311

jahway603 avatar Oct 22 '22 01:10 jahway603

@networkException is the "pr-waiting-for-author" tag an indication for me to do something else on this PR?

jahway603 avatar Oct 27 '22 14:10 jahway603

Yes I left another review requesting a change

networkException avatar Oct 27 '22 14:10 networkException

@networkException I don't see that anywhere in this PR. What am I missing?

jahway603 avatar Oct 27 '22 15:10 jahway603

Oh my bad, GitHub mobile didn't show this as pending

networkException avatar Oct 27 '22 15:10 networkException

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Oct 27 '22 15:10 BuggieBot

@networkException fixed that and squashed the commits. Anything else I need to do to get this PR merged?

jahway603 avatar Oct 27 '22 15:10 jahway603

Unless a maintainer requests changes, no

networkException avatar Oct 27 '22 15:10 networkException

https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md#code-submission-policy

Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work").

linusg avatar Oct 27 '22 19:10 linusg

https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md#code-submission-policy

Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work").

@linusg Any other changes that are needed before this PR is merged?

jahway603 avatar Oct 28 '22 16:10 jahway603

@networkException does this PR need to be "re-advertised" or what's the next step here?

jahway603 avatar Oct 31 '22 15:10 jahway603

@linusg what else needs to be resolved for this PR to be merged?

jahway603 avatar Nov 07 '22 19:11 jahway603