serenity
serenity copied to clipboard
Base: Added manpages for which(1) and stat(1)
Added manpages for which(1) and stat(1)
Added manpages for Issue https://github.com/SerenityOS/serenity/issues/11311
@networkException is the "pr-waiting-for-author" tag an indication for me to do something else on this PR?
Yes I left another review requesting a change
@networkException I don't see that anywhere in this PR. What am I missing?
Oh my bad, GitHub mobile didn't show this as pending
Hello!
One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits
CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.
@networkException fixed that and squashed the commits. Anything else I need to do to get this PR merged?
Unless a maintainer requests changes, no
https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md#code-submission-policy
Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work").
https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md#code-submission-policy
Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work").
@linusg Any other changes that are needed before this PR is merged?
@networkException does this PR need to be "re-advertised" or what's the next step here?
@linusg what else needs to be resolved for this PR to be merged?