serenity icon indicating copy to clipboard operation
serenity copied to clipboard

LibJS: More spreading support for the Bytecode-VM

Open Hendiadyoin1 opened this issue 3 years ago • 4 comments

Also hopefully includes a fix for #12127

Hendiadyoin1 avatar Sep 02 '22 21:09 Hendiadyoin1

Ok, ci says, i screwed up sizes somewhere or something, Will investigate later

Hendiadyoin1 avatar Sep 02 '22 22:09 Hendiadyoin1

Ok, ci says, i screwed up sizes somewhere or something, Will investigate later

Looks like the #12127 problem, quite an annoying one, you can probably just move around the js source in bytecode to fix it

davidot avatar Sep 02 '22 22:09 davidot

Ups i left a few debug prints in here...

Hendiadyoin1 avatar Sep 08 '22 00:09 Hendiadyoin1

@linusg is the added note sufficient?

Hendiadyoin1 avatar Sep 09 '22 14:09 Hendiadyoin1

Gonna leave this one up to @alimpfard - if you want to block on simplifying the opcodes as mentioned in the discussions above, feel free.

linusg avatar Sep 20 '22 12:09 linusg

Let's have the feature, we can simplify later, no need to block.

alimpfard avatar Sep 20 '22 12:09 alimpfard

@alimpfard That made codegen a but easier Is this version to your linking?

Hendiadyoin1 avatar Sep 20 '22 15:09 Hendiadyoin1