serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Documentation: Restructure wording to align with intended meaning

Open Jonta opened this issue 2 years ago • 7 comments

Previously, the meaning would be closer to "having a monorepo is not a sufficient reason to add a package manager"

What was more likely meant is "the reason we don't have a package manager, is that we use a monorepo"

Similar to "There is no reason to get cake just because you took the bins out", vs. "The reason you're not getting cake, is that you already have ice cream"

Jonta avatar Jul 04 '22 21:07 Jonta

Ah yes. "Docs" is an old habit from projects with less rigid requirements

I was very unsure of the commit message, wanting to keep it at or below 50 characters as well

"Documentation: Restructure wording" fits, but if I had the space, I would've chosen something like "Documentation: Restructure wording to align with intended meaning"

Jonta avatar Jul 05 '22 15:07 Jonta

@Jonta Documentation: Restructure wording to align with intended meaning is fine as the limit is 72 characters not 50. Also you've only changed the title of your PR not your commit message. To change the commit message do:

git commit --amend
<update the title>
git push -f 

MacDue avatar Jul 06 '22 00:07 MacDue

@MacDue Thanks

I'm still using GitHub's web interface for this

Does editing the comment (as I did just now) change the commit message? :)

Jonta avatar Jul 07 '22 12:07 Jonta

No. You'll need a local checkout, amend the commit, and force push - none of this is possible via the web interface, best to forget that it even exists :^)

linusg avatar Jul 07 '22 12:07 linusg

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Jul 29 '22 01:07 stale[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Aug 31 '22 01:08 stale[bot]

I thought marking as draft would protect it from Stalebot

Jonta avatar Sep 06 '22 09:09 Jonta

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Sep 27 '22 12:09 stale[bot]

Activity

Jonta avatar Oct 01 '22 18:10 Jonta

Please just update the PR if you intend to make it mergeable, instead of artificially keeping it alive.

linusg avatar Oct 01 '22 21:10 linusg

Please just update the PR if you intend to make it mergeable, instead of artificially keeping it alive.

  • I predict that's not going to happen for at least another 2 months
  • Hence closing this for now

Jonta avatar Oct 02 '22 21:10 Jonta