serenity
serenity copied to clipboard
Documentation: Restructure wording to align with intended meaning
Previously, the meaning would be closer to "having a monorepo is not a sufficient reason to add a package manager"
What was more likely meant is "the reason we don't have a package manager, is that we use a monorepo"
Similar to "There is no reason to get cake just because you took the bins out", vs. "The reason you're not getting cake, is that you already have ice cream"
Ah yes. "Docs" is an old habit from projects with less rigid requirements
I was very unsure of the commit message, wanting to keep it at or below 50 characters as well
"Documentation: Restructure wording" fits, but if I had the space, I would've chosen something like "Documentation: Restructure wording to align with intended meaning"
@Jonta Documentation: Restructure wording to align with intended meaning
is fine as the limit is 72 characters not 50.
Also you've only changed the title of your PR not your commit message. To change the commit message do:
git commit --amend
<update the title>
git push -f
@MacDue Thanks
I'm still using GitHub's web interface for this
Does editing the comment (as I did just now) change the commit message? :)
No. You'll need a local checkout, amend the commit, and force push - none of this is possible via the web interface, best to forget that it even exists :^)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
I thought marking as draft would protect it from Stalebot
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
Activity
Please just update the PR if you intend to make it mergeable, instead of artificially keeping it alive.
Please just update the PR if you intend to make it mergeable, instead of artificially keeping it alive.
- I predict that's not going to happen for at least another 2 months
- Hence closing this for now