serenity
serenity copied to clipboard
SerenityOS
Toolchain: Extract and patch QEMU only if patches have changed
Quick question: is that patch even needed? The commit is dated February 2022, and 7.0 was released in April, so it's likely already included in the release.
Indeed, the patch isn't needed. The reason why it wasn't caught is because the commit that was eventually merged (qemu/qemu@9584d3d00a454f47b0341465142bcf0735d734ae) was a different one than what we have used as our patch.
In that case, I'll probably put this PR on hold, and revisit this once the QEMU people (hopefully) come up with a fix for the SPICE issue that we have been seeing (and just roll this commit, the removal of our custom -fcf-protection patch, and the addition of the bug fix into this PR).
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!