serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Help: Application icons are misaligned

Open linusg opened this issue 2 years ago • 1 comments

Might be an issue with the generated HTML / styles, or a rendering bug in LibWeb.

image

vs man.serenityos.org:

image

linusg avatar May 04 '22 17:05 linusg

fwiw it looks like this generates the same html for that line (same on my browser and the serenity rendered one)

<p><img src="[../icons/16x16/ladyball.png](view-source:http://man.serenityos.org/icons/16x16/ladyball.png)" alt="Icon" /> About - About SerenityOS</p>

and functions the same way if you scale this image up on man.serenityos.org (the icon will be larger than the text and text is aligned at the bottom). So I guess this rules out the generated html

Could this just be due to the default text size differences ? (could still be an issue, maybe there's some standard that the text should be a certain height and/or we're not rendering one of the components correctly)

JsFlo avatar Aug 22 '22 01:08 JsFlo

I think it looks OK in Help currently.

I took screenshots in Help, man.serenityos.org in Browser and in Chrome

In Chrome the text is larger but in all three the bottom is aligned the same with the text. There is 1px between the bottom of the icon and the text base line (see the blue line that I added in the screenshots below)

helpicons

premek avatar Oct 29 '22 17:10 premek

We could use some flexbox shenanigans to achieve universal centered vertical alignment, but this seems ok. Thanks for checking!

linusg avatar Oct 29 '22 18:10 linusg