serenity
serenity copied to clipboard
PixelPaint: Make Alt-Clicking with Pen/Brush tool act like the Color Picker tool
This is a common feature in other drawing apps which makes switching between colors a lot easier.
Hi @mustafaquraish I'm new to this project and would like to work on this issue. I saw the earlier PRs
You mentioned : "There's already some code in CloneTool that handles changing the color to an eyedropper when in selection mode while pressing down alt. I think it would be nice if you could factor that out into the Brush class so that all the tools feel consistent (and we have a visual indicator of whether we're selecting a color or not)."
So I have some questions:
- Should all the classes inherited from BrushTool Class have this functionality
- My proposal:
- BrushTool class implements the on_keydown & on_keyup functions with the default behavior (alt changes to color picker)
- The derived classes can override the functions for specific functionality Does that seem ok?
@atharva1910 If you're still around: Please come to the Discord server, and ask in the #pixel-paint channel. That's where most discussion happens, and that way everyone involved in PixelPaint will see your message. :^)
This feature is implemented in 813ca5ebbe3fce7a65f6a1f3ef990b07ac6929a2 and further worked on in 2f5bbc68. This issue can be closed.