serenity icon indicating copy to clipboard operation
serenity copied to clipboard

Calculator: Move towards a Calculator without any numerical errors

Open LucasChollet opened this issue 4 years ago • 8 comments

The purpose of this PR is to enhance the calculator, mainly by removing numerical errors.

Current progress:

  • [x] Support any number
  • [x] Support flawless +, -, *
  • [x] Display rounded numbers
  • [x] Support /, inv without conversion to double
  • [x] Enhance user interaction with rounding

Needed fixes:

  • [x] Entering a floating point number is really buggy
  • [x] Take care of remaining zeros after the comma
  • [x] Unable to enter an integer after clearing while entering a floating point

Closes #14062

LucasChollet avatar Jan 04 '22 20:01 LucasChollet

@creator1creeper1 Any thought on this?

LucasChollet avatar Jan 04 '22 20:01 LucasChollet

Very cool! I feel like the resulting code would be even nicer if we extracted out the idea of "fraction of BigIntegers" into a new class such as BigFraction.

creator1creeper1 avatar Jan 15 '22 23:01 creator1creeper1

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar May 17 '22 19:05 stale[bot]

I only resolved a simple merge conflict.

LucasChollet avatar Jun 11 '22 21:06 LucasChollet

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Jul 03 '22 02:07 stale[bot]

Boo :ghost:

MacDue avatar Jul 03 '22 18:07 MacDue

Going on a "what if I make 8 small PRs out of this one" crusade

LucasChollet avatar Jul 09 '22 14:07 LucasChollet

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

stale[bot] avatar Jul 30 '22 14:07 stale[bot]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!

stale[bot] avatar Aug 06 '22 16:08 stale[bot]