jakt icon indicating copy to clipboard operation
jakt copied to clipboard

Fix: main function does not check inferred return type nor namespacevar type

Open Pablo96 opened this issue 3 years ago • 2 comments

What does this PR do?

It fixes issue 483

Description of the bug it fixes

On the main function, given no explicit return value it does not check the inferred type against is_integer, it is related to another bug I found where if the expression is a NamespacedVar it does not check for its type either.

Pablo96 avatar Jun 25 '22 00:06 Pablo96

Hello!

One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Jun 25 '22 00:06 BuggieBot

This is still failing rustfmt on CI. Also, please squash the fixup into the original commit instead of adding a separate commit :)

awesomekling avatar Jun 28 '22 08:06 awesomekling

Closed as this is a change for the now-gone Rust-based compiler. Feel free to port your changes to the new compiler, if they're not already added, and open a new PR. :^)

AtkinsSJ avatar Aug 26 '22 22:08 AtkinsSJ