jakt icon indicating copy to clipboard operation
jakt copied to clipboard

parser: Check for comma after parameter in function call

Open f1ypopper opened this issue 2 years ago • 3 comments

f1ypopper avatar Jun 02 '22 17:06 f1ypopper

Hello!

One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar Jun 03 '22 02:06 BuggieBot

Hey @jntrnr can you please review the PR again?

f1ypopper avatar Jun 04 '22 02:06 f1ypopper

@f1ypopper - looks like you'll need to follow the submission guidelines that BuggieBot links to.

Also, you should add a test to show that the error is working

sophiajt avatar Jun 04 '22 18:06 sophiajt

Closed as this is a change for the now-gone Rust-based compiler. Feel free to port your changes to the new compiler, if they're not already added, and open a new PR. :^)

AtkinsSJ avatar Aug 26 '22 22:08 AtkinsSJ