jakt icon indicating copy to clipboard operation
jakt copied to clipboard

codegen: Generate code for generic classes

Open mmeeaallyynn opened this issue 3 years ago • 5 comments

Generics are mostly working for structs and enums, but generic classes were not considered in the code for the most part.
This should fix them for the most part. The only thing missing is type inference when accessing members, but I feel like this is out of scope for this pull request.

mmeeaallyynn avatar May 28 '22 09:05 mmeeaallyynn

Hello!

One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

BuggieBot avatar May 28 '22 09:05 BuggieBot

@mmeeaallyynn - thanks for the PR. Looks like you'll need to run it through cargo fmt to use the standard code formatting.

sophiajt avatar May 29 '22 01:05 sophiajt

Please update the tests to follow the new format from 99a337b5734ac8f8c74ecdcb545dfe9cabde956d

Also, please squash your commits, we shouldn't be failing CI after any single commit in your PR.

mustafaquraish avatar May 29 '22 12:05 mustafaquraish

It seems like you have rebased/pulled main ontop of your changes instead of the other way around, please rebase your changes onto main instead

Hendiadyoin1 avatar May 30 '22 10:05 Hendiadyoin1

Thanks for the pointer, this did seem off to me after looking at other PRs.

mmeeaallyynn avatar May 30 '22 11:05 mmeeaallyynn

Closed as this is a change for the now-gone Rust-based compiler. Feel free to port your changes to the new compiler, if they're not already added, and open a new PR. :^)

AtkinsSJ avatar Aug 26 '22 22:08 AtkinsSJ