jakt
jakt copied to clipboard
codegen: Generate code for generic classes
Generics are mostly working for structs and enums, but generic classes were not considered in the code for the most part.
This should fix them for the most part. The only thing missing is type inference when accessing members, but I feel like this is out of scope for this pull request.
Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.
@mmeeaallyynn - thanks for the PR. Looks like you'll need to run it through cargo fmt to use the standard code formatting.
Please update the tests to follow the new format from 99a337b5734ac8f8c74ecdcb545dfe9cabde956d
Also, please squash your commits, we shouldn't be failing CI after any single commit in your PR.
It seems like you have rebased/pulled main ontop of your changes instead of the other way around,
please rebase your changes onto main instead
Thanks for the pointer, this did seem off to me after looking at other PRs.
Closed as this is a change for the now-gone Rust-based compiler. Feel free to port your changes to the new compiler, if they're not already added, and open a new PR. :^)