jakt icon indicating copy to clipboard operation
jakt copied to clipboard

Published 20 hours ago • verified publisher icon SerenityOS

parser+typerchecker+codegen+tests: Tuple destruction

Open AndrewBregger opened this issue 3 years ago • 5 comments

Allow for tuple destruction during variable declaration.

AndrewBregger avatar May 28 '22 06:05 AndrewBregger

I think you mean destructuring and not destruction.

creator1creeper1 avatar May 28 '22 06:05 creator1creeper1

If you merge main, you should get the fix to the enum tests.

sophiajt avatar May 28 '22 07:05 sophiajt

If you merge main, you should get the fix to the enum tests.

sophiajt avatar May 28 '22 07:05 sophiajt

Please squash your commits. It's not ideal having 2 commits undoing / changing something you implemented in the first - the history becomes messier.

mustafaquraish avatar May 28 '22 19:05 mustafaquraish

Please update the tests to follow the new format from 99a337b5734ac8f8c74ecdcb545dfe9cabde956d

mustafaquraish avatar May 29 '22 12:05 mustafaquraish

Closed as this is a change for the now-gone Rust-based compiler. Feel free to port your changes to the new compiler, if they're not already added, and open a new PR. :^)

AtkinsSJ avatar Aug 26 '22 22:08 AtkinsSJ