Serene

Results 168 comments of Serene

@sampsyo There's really no single best approach imo. Perhaps for git reasons, changing the least used parts would be easiest first and less likely to impact other people's PRs and...

That's probably a good idea, I can start with that. There is a pitfall that I and everyone else who attempts this has to be aware of though. The typings...

So I've started typing `dbcore` and I'll have that up in a PR soon for people to view. I still need to go and crossreference things and try and reconcile...

@wisp3rwind I tried that to begin with but if you look at the code, you can see that any modifications to the file overwrite the original. So for my configuration,...

I did not test that. I tested with singletons and albums, but I'll look into fixing this. Thanks for letting me know a case! I tried to hook into the...

@arsaboo then I'll fix that bug while I'm at it! I have a solution in mind, I just have to test it and make sure all of the code works....

@sampsyo it does make more sense as a config specific option, can do that for sure. As for other variables for judging the quality, I broke out the function for...

So right now the files are only replaced when there's a replacement. However the tests are a bit messed up by this behaviour, I'll try and fix those next. Also,...

@sampsyo For the importer, should it leave items that are not getting replaced in general, or is that something that should be only for the upgrade option? Like, if an...